Form Generation Library

[eluser]Unknown[/eluser]
Just to save anyone else the problem - if you're using two forms on one page you need to make ALL the form fields are uniquely named. You might get away with it depending on the overlap and your rules but you might also get unintended results.

The reason is the way the library decides if the form has been submitted: it's in this function below.

Code:

function _check_post()
    {
        foreach ($this->_elements as $el)
        {
            if ($el['name'])
            {
                $name    = str_replace('[]', '', $el['name']);

                if (isset($_POST[$name]))
                {
                    $this->_posted = TRUE;
                    break;
                }
            }
        }
    }

Essentially what it's doing is looping through the form elements and checking the post array to see if the element is in there. So you could have two forms with 100 fields each and it'll check items [0] through [99] and if JUST ONE OF THEM is identically named and set it'll believe the form was posted. At which point it kicks off the validations, populates the error fields, etc.

The real danger is if you pass validation anyway - then you'll fire off your various events and potentially take some actions, redirect, etc. I confirmed this by turning off all validation on form 1 and pressing the submit button on form 2. It called my model and inserted a record with all kinds of junk because it was using unpopulated post values.

Simply insuring all your fields are uniquely named (I just put FORM1 or FORM2 in front of all my fields) will prevent the problem though it does mean you can't re-use models unless you cope with that within them.

I'm under deadline or I'd look for a more elegant solution - maybe checking the form name in the validate function where _check_post() gets called?