casting could clean some code |
[eluser]sophistry[/eluser]
hi tomfoth and welcome to CI. in my experience working with CI and seeing it evolve, the only time the CI devs will change code that is already proven and working is if you prove a startling difference in performance or uncover a real bug. suggesting changing some bit of code that is working but has one extra if statement or one verbose expression is not going to get *any* traction. i love slim code and optimizing as much as the next advancing programmer, but at some point you have to focus on the bigger picture. ![]() here's an example of forum-developed code that actually convinced somebody inside Ellis Labs and they went ahead and used it: http://ellislab.com/forums/viewthread/51788/ WRT array casting, i believe it has implications for code readability and clarity as well as error reporting - however, i couldn't expound on it OTTOMH. also, supposing someone wanted to change that code to do a few more things when no array was detected... it's somewhat future proof because it is clear and structured (i know, lame argument). cheers! |
Messages In This Thread |
casting could clean some code - by El Forum - 04-03-2009, 06:16 AM
casting could clean some code - by El Forum - 04-03-2009, 06:53 AM
casting could clean some code - by El Forum - 04-03-2009, 06:58 AM
casting could clean some code - by El Forum - 04-03-2009, 07:59 PM
casting could clean some code - by El Forum - 04-08-2009, 03:26 AM
|