[eluser]OverZealous[/eluser]
I want to notify everyone of a small problem with the new validate-get method:
Before, the method would only query on non-empty() fields. This meant that an empty password would be simply be ignored, which was the original issue. (This didn't affect username, because you need at least username to look up the user.)
So I changed that to only query non-NULL fields. This eliminated the empty field issue. It did, however, create an entirely new issue: If you (like me) use the trim pre-processing rule before the required rule, a NULL field will be converted into '' (empty string), due to the way the trim method works.
Therefore, the logins on my application failed.
My proposed solution is to add a _trim rule directly to DMZ, that ignores empty fields. This seems to work very well. I don't want to implement it until I have had more time to test, though.
If you are having trouble with 1.4.3, Add this to either libraries/datamapper.php or any class that uses required, trim, and gets looked up with validate->get:
Code:
/**
* Trim
* Custom trim rule that ignores NULL values
*
* @access public
* @param string
* @return bool
*/
function _trim($field) {
if( ! empty($this->{$field})) {
$this->{$field} = trim($this->{$field});
}
}
