Carabiner 1.4: Asset Management Library

[eluser]tonydewan[/eluser]
@quasiperfect I'm glad you got it to work.

@topherdan1 That looks like a really solid solution! There are a few things you could change to make the code a little simpler:

First, you can just do

Code:

if($this->use_cdn && !$this->dev)

instead of

Code:

if($this->CI->config->item('use_cdn') === TRUE && $this->dev == FALSE)

That's because the config function is lazy, and will drink up whatever items are in the config file (or array) and make them class variables. That also applies to anyplace you use this syntax:

Code:

$this->CI->config->item('')

The only other thing I would do is adjust the logging in the cache function, so it looks something like this:

Code:

private function _cache($filename, $file_data)
    {
        $filepath = $this->cache_path . $filename;
        $success = file_put_contents( $filepath, $file_data );

        if($success) :
            log_message('debug', 'Carabiner: Cache file '.$filename.' was written to '.$this->cache_path);
      
            if($this->use_cdn == TRUE && $this->dev == FALSE):

                $this->CI->load->library('S3');
                $cdn = $this->CI->s3->putObjectFile($filepath, $this->cdn_bucket, $this->cache_dir.$filename, S3::ACL_PUBLIC_READ);
                
                if($cdn){
                    log_message('debug', 'Carabiner: Cache file '.$filename.' was written to the CDN bucket '.$this->cdn_bucket);
                    return TRUE;
                }else{
                    log_message('error', 'Carabiner: There was an error writing cache file '.$filename.' to  the CDN bucket '.$this->cdn_bucket);
                    return FALSE;
                }
    
            endif;
      
            return TRUE;
        else :
            log_message('error', 'Carabiner: There was an error writing cache file '.$filename.' to '.$this->cache_path);
            return FALSE;
        endif;
    }

These are all minor things, though.