Carabiner 1.4: Asset Management Library

[eluser]Mark Croxton[/eluser]
Thanks so much for this very useful library! I'm using the latest beta for a form automation framework but came across a small bug: when you don't have any of your included assets combined or minified a link to a non-existent cache file is still output.

The problem is around line 606-608 of the library file for js:

Code:

if( !file_exists($this->cache_path.$filename) )    $this->_combine('js', $files, $filename);

echo $this->_tag('js', $filename, TRUE);

For CSS around lines 752 - 758:

Code:

if( !file_exists($this->cache_path.$filename) ) $this->_combine('css', $files, $filename);

echo $this->_tag('css',  $filename, TRUE, $media);

Your code is not checking that a cache file was actually created before echoing a link to it... maybe you could have _combine() return true or false and check this before outputting the link? Or even better, check if _combine() needs to be run at all.