[Deprecated] DMZ 1.6.2 (DataMapper OverZealous Edition)

[eluser]TheJim[/eluser]

I don’t agree that your second suggestion is necessary:
1) In the first case (an empty array), there is no harm, because at most you might get an extra function call. Since this is saving (not getting), there isn’t any real performance boost.

2) In the second case (not empty), the array should always be edited by reference in PHP 5+, which is all that is supported. Re-assigning it isn’t really necessary.

I agree with #2. Actually, I only added that in when I posted in the forum. For some reason, I felt like I was missing a case when I wrote the post, but yes, references should take care of it.

However, I still think the empty case is necessary, not for performance reasons, but because if the related object is saved with ITFK and passed in an array, but not unset, then when we get to

Code:

(Line 1096)
        // Check if a relationship is being saved
        if ( ! empty($object))
        {
            // save recursively
            $this->_save_related_recursive($object, $related_field);

            $trans_complete_label[] = 'relationships';
        }

$object isn't empty, so _save_related_recursive raises an error. I don't remember exactly where it happened, but this is what I came across when integrating DMZ into my work-flow, so I could back-track and give a more detailed example if necessary.

I think you are correct in your third suggestion. However, using the solution you provided will not work, as all fields will be copied over, even if there is a collision. I’ll work up a solution.

I think in my mind I wasn't considering those situations because it would be kind of a bad field naming scheme. But it could definitely happen, so you're right; you would want to keep what you had before with a special case only for the ITFK.

I'll check into get_sql; I was unaware of its existence.

Thanks.

Jim