DMZ 1.7.1 (DataMapper OverZealous Edition)

[eluser]uptime[/eluser]
I think I've found an issue with DMZ and PHP > 5.3.0.

Example code:

Code:

$m->include_related('some_model', NULL, TRUE, TRUE /* instantiate */);

Code:

var_dump( $m->some_model->exists() ); // Outputs TRUE, however, the data does not exist (NULL);

After some debugging, I've found that DMZ may not instantiate the related model correctly due to a PHP bug.

Bugfix/Workaround:

In _to_object(), replace:

Code:

foreach ($this->fields as $field)
{
    if (! isset($row->{$field}))
    {
        $item->{$field} = NULL;
    }
}

With the following:

Code:

foreach ($this->fields as $field)
{
    //if (! isset($row->{$field}))
    
    /**
     * Workaround for PHP > 5.3.0
     *
     * Please let me know if you have any comments, suggestions or updates;
     * I hope my issue wasn't due to misuse of DMZ. Issue occurs on PHP 5.3.2;
     *
     * @author [email protected]
     * @see http://bugs.php.net/49269
     */
    if (! isset($row->{$field}) && ( is_array($row) && ! isset($row[$field]) ) )
    {
        $item->{$field} = NULL;
    }
}

It fixed my issue on PHP 5.3.2.

Did anyone else have such an issue?

Edit: The correct way of fixing this would probably to use the __isset() magic function on the DataMapper object to prevent the same issue from happening again.