[eluser]WanWizard[/eluser]
Yes, I did. But before I could finish my reply to that I had to go into a meeting. Have to make some money every now and then...
[quote author="skunkbad" date="1280490971"]1) Once we are getting the value of allow_get_array from our new config variable, why do we care if there is a enable_query_strings variable in the Input class? It doesn't seem to get used anywhere in the class. Are other classes checking this value here instead of getting it from the config class?
2) What is the reason why the Input class needs to load between Config and URI?[/quote]
Good questions.
I just ran an svn diff and posted the results here, might be that some leftovers from earlier changes made it to the diff.
I'll review the changes, you could probably get away with simply changing
Code:
$this->allow_get_array = ($CFG->item('enable_query_strings') === TRUE) ? TRUE : FALSE;
to
Code:
$this->allow_get_array = ($CFG->item('allow_get_array') === TRUE) ? TRUE : FALSE;
and adding that config value to your config file.
EDIT: no, you need the modification of URI.php too, to avoid using $_GET when the uri_protocol is AUTO:
Code:
if ($this->config->item('enable_query_strings') === TRUE && is_array($_GET) && count($_GET) == 1 && trim(key($_GET), '/') != '')
EDIT2: I now realise where the diff entries come from. I first modified the meaning of the existing config key 'enable_query_string', which required modifications in codeigniter.php and router.php as well. I decided later that it wasn't handy, and created the new 'allow_get_array' config key, which is a much simpler change. Unfortunately, I generated the diff using the wrong repo revisions as reference, which severly messed things up.
Thanks for pointing this out, and sorry to all of you, for making this sound more complicated than it was.
