form validation question

[eluser]SitesByJoe[/eluser]
Your structure looks pretty good.

You're correct with the way things work, of everything passes validation, the post data should be safe to add to the database.

Things to improve it would be to move your rule declarations into a form_validation config file (see userguide) and moving some of your database calls inside your if() conditional since you only need them when calling your form, not when processing your post data.

Another thing I like to do is to set a success message and then redirect after running the database sequence. Something like:

Code:

// set a temporary success message
$this->session->set_flashdata('message', 'Post added successfully');

// redirect to a new screen based on our new id
redirect('controller/method/' . $this->db->insert_id());

I then run a conditional check on my view template that pops up if the flashdata message has been set.