New to CI - check out my code and tell me if what I'm doing is efficient...

[eluser]johnnybravoh[/eluser]
Model Agent.php

Code:

<?
class Agent extends Model {

    var $title   = '';
    var $content = '';
    var $date    = '';

    function Agent(){
    
        parent::Model();
    }


    function add(){
    
        $el=array('name','address1','address2','city','state','zip','phone','email');
        foreach ($el as $item){
            $this->item->$item=$_POST[$item];
        }
        $this->item->picture=$this->session->userdata('img_name');
        $this->db->insert('agent', $this->item);
    
    }
}
?>

View _agent_form.php

Code:

<!--BEGIN AGENT FORM DIV-->
<div id="agentManagement">
<fieldset>
<legend>&lt;?=$heading?&gt;</legend>
    &lt;?=(isset($my_picture)?$my_picture:'')?&gt;
&lt;?=form_open_multipart($this->uri->uri_string(), array('id' => 'agent_form'))?&gt;
      <p><label for="name">Agent Name :</label>
      &lt;?=form_input($name_options)?&gt;
     &lt;?=(isset($this->validation->name_error) ? $this->validation->name_error:'');?&gt;
    </p>

      <p><label for="address1">Address 1 :</label>
      &lt;?=form_input($address1_options)?&gt;
        &lt;?=(isset($this->validation->name_error) ? $this->validation->address1_error : '')?&gt;
      </p>
    <p><label for="address2">Address 2 :</label>
    &lt;?=form_input($address2_options)?&gt;
        &lt;?=(isset($this->validation->address2_error) ? $this->validation->address2_error : '')?&gt;
    </p>
      <p><label for="city">City :</label>
      &lt;?=form_input($city_options)?&gt;
    &lt;?=(isset($this->validation->city_error) ? $this->validation->city_error : '')?&gt;
      </p>
      <p><label for="state">State :</label>
      &lt;?=form_input($state_options)?&gt;
    &lt;?=(isset($this->validation->state_error) ? $this->validation->state_error : '')?&gt;
      </p>
      <p><label for="zip">Zip :</label>
      &lt;?=form_input($zip_options)?&gt;
    &lt;?=(isset($this->validation->zip_error) ? $this->validation->zip_error : '')?&gt;
      </p>
      <p><label for="email">Email :</label>
      &lt;?=form_input($email_options)?&gt;
    &lt;?=(isset($this->validation->email_error) ? $this->validation->email_error : '')?&gt;
      </p>
      <p><label for="phone">Phone :</label>
      &lt;?=form_input($phone_options)?&gt;
    &lt;?=(isset($this->validation->phone_error) ? $this->validation->phone_error : '')?&gt;
      </p>
      <p><label for="picture">Picture :</label>
      &lt;?=form_upload($picture_options)?&gt;
    &lt;?=(isset($picture_err) ? $picture_err: '')?&gt;
      </p>
            &lt;input type="submit" name="Submit" value="Submit" class="submit"/&gt;
            &lt;input type="reset" name="Reset" value="Reset" /&gt;
&lt;/form&gt;
</fieldset>
</div>&lt;!--END AGENT FORM DIV--&gt;