Welcome Guest, Not a member yet? Register   Sign In
Codeigniter development (v3.0)
#3

[eluser]wiredesignz[/eluser]
@Aken, I know what the code does.

So what prevents a creative developer from using simple routing like so:
Code:
$route['(.*)-(.*)'] = '$1_$2';

It seems pointless hacking something into the codebase that can be solved with a little thought on the user's part.

Your idea of flexibility is only valid if the changes are easily understandable and will be implemented by a decent percentage of users. I do not see this happening here. Bloat occurs if code, which is never going to be used, is added to any software.

In fact adding reverse routing to CI would be much more beneficial to the majority of developers than both of these hacks.

EDIT:
I am concerned also, from looking at the examples posted for the processed routes, that they are attempting to set the base business logic for an application inside the routes closures. Thus if the controller or model doesn't also enforce business logic then altering routing will cause the application to fail. Routes should not do this, they should direct traffic not establish rules.

Reference: https://github.com/EllisLab/CodeIgniter/pull/1636

Default page numbers and other values should be set in the page controller, not in the routing.

Copying Laravel routing methodology might be cute, but they're missing the point entirely.


Messages In This Thread
Codeigniter development (v3.0) - by El Forum - 11-07-2012, 05:38 AM
Codeigniter development (v3.0) - by El Forum - 11-07-2012, 09:55 PM
Codeigniter development (v3.0) - by El Forum - 11-07-2012, 10:27 PM
Codeigniter development (v3.0) - by El Forum - 11-08-2012, 11:11 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 12:25 AM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 03:06 AM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 03:37 AM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 03:40 AM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 04:13 AM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 01:36 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 01:45 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:00 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:06 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:10 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:16 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:22 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:39 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:41 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 02:56 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 03:04 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 09:29 PM
Codeigniter development (v3.0) - by El Forum - 11-09-2012, 10:37 PM
Codeigniter development (v3.0) - by El Forum - 11-10-2012, 01:01 AM



Theme © iAndrew 2016 - Forum software by © MyBB