Single Responsibility Principal

[eluser]Otemu[/eluser]
Hi,

You could make better use of the Codeigniter Validation class, for instance you have a lot of

Code:

if (strtotime($user_data->lock_date) > $current_time)
                                {
                                        // User is still locked out
                                        $output_status = 'Error';
                                        $output_title = 'Account Locked';
                                        $output_message = 'This user account is current locked!';
                                        $x++;
                                }

The validation system supports callbacks to your own validation functions. This permits you to extend the validation class to meet your needs. For example, if you need to run a database query to see if the user is choosing a unique username, you can create a callback function that does that

So for instance to check status you could run a callback:

Code:

$this->form_validation->set_rules('username', 'Username', 'required|check_status');
public function check_status($str)
{
  if (//your check)
  {
                        //your code
   $this->form_validation->set_message('check_status', 'status message"');
   return FALSE;
  }
  else
  {
   return TRUE;
  }
}

Quite a few of your if else statements can also be changed to just switch statements. Then just use set_message for each one.
You can also save sets of rules in a config file Form Validation

Also check out Flattening Arrow Code and The Single Responsibility Principle