Welcome Guest, Not a member yet? Register   Sign In
Have I made form function secure enough
#3

(This post was last modified: 04-02-2016, 10:44 PM by Diederik.)

You are not validating the value of $_GET['banner_form_id'], you only check if it exists. Based on the name of the variable I would guess it would represents an integer based id. Eventhough GET variables are filtered by the config (default value: $config['permitted_uri_chars'] = 'a-z0-9~%.:_\-'Wink and your code does not represents any harmful processing (although a bit over-complexing solution to a simple situation).

I would suggest some small modification like:
PHP Code:
$banner_form_id intval$this->input->get('banner_form_id')); 

About your CSRF question. Genaraly there are few reasons why you should not use it although the impact of a succesfull CSRF attack depends on what functionality the form has and the role of the current user.
For more details I would refer you to: https://www.owasp.org/index.php/Cross-Si...heat_Sheet
Reply


Messages In This Thread
RE: Have I made form function secure enough - by Diederik - 04-02-2016, 10:40 PM



Theme © iAndrew 2016 - Forum software by © MyBB