Welcome Guest, Not a member yet? Register   Sign In
Webigniter - developer-first CMS built with Codeigniter 4
#4

(This post was last modified: 08-28-2023, 12:35 PM by ozornick.)

0. setcookie('hash', '', time() + (60*60*24*365), '/'); It is a good practice to set the time in the past

1. You have implemented Models in the Entity. It's also a bad addiction (my opinion ActiveRecord is bad).

2. header('location: ***');
WTF? You developer - use Response.

3. Read about php-cs-fixer.

4. In base controller $this->data['session'] = Services::session(); but in many methods (or Entity) reinitializes the session. What for?

... There are many small comments.
Simple CI 4 project for beginners codeigniter-expenses
Reply


Messages In This Thread
RE: Webigniter - developer-first CMS built with Codeigniter 4 - by ozornick - 08-28-2023, 12:34 PM



Theme © iAndrew 2016 - Forum software by © MyBB