Proposal: Add isPast() and isFuture() to CodeIgniter 4 Time Class

I would argue that it doesn't make the code any more readable. Requiring a dev to input Time::now() makes it obvious the method is used for a temporal comparison.

It certainly qualifies as a convenience/efficiency method but its use case is already covered by the more general isBefore, isAfter.

If someone specifically desired these methods coudn't they create their own Time class that uses TimeTrait and add these methods? Am I missing something that makes these methods necessary?

Wouldn't it also be possible to refactor isBefore and isAfter to check if the passed time is null and assume Time::now() so that isPast and isFuture aren't required at all? The point of this is to say that isBefore() and isAfter() is no less confusing than isPast() or isFuture() without a parameter. You're trying to use the idea of isPresent in your mind to indicate that Time::now() is obvious, but I could also say that there is an imaginary isNow that relates to isBefore and isAfter.

Halberd | CodeIgniter Sandbox