Modular Extensions - HMVC version 5.2

[eluser]dcunited08[/eluser]
[quote author="wiredesignz" date="1240397234"]Personally I can't see why you would need to declare vars for your loaded objects when CI replaces them anyway, but, if you need this functionality you could use the PHP4 version of Modular Extensions.[/quote]

@wiredesignz

I understand why you set it up to use a static variable but it, to me, seems to remove one of the basic fundamentals of OOP, encapsulation. The property name is no longer unique to the controller object, if loaded via the load object, so it is probable to have another module replace that object. Please review my test code below to see what I mean.

Code:

class Welcome extends Controller {
    
    function Welcome()
    {
        parent::Controller();
    }

    function index()
    {
        $this->load->library('table', array(), 'test1');
        $this->test1->add_row('asdf','qwer');
        $this->load->view('welcome_message');
        $asdf = $this->load->module('Test2');
        $asdf->index();
        
        $this->test1->add_row('asdf2','qwer2'); //Call to undefined method TestMe::add_row()
        
     }
}

class Test2 extends Controller{

    function index()
    {
        $this->load->view('welcome_message');
        $this->load->library('TestMe', array(), 'test1');
        $this->test1->run();
    }
}

In my application, I use $loaded_model quite a lot because I dynamically load models based on what type of data the user is requesting. This allows me to define a parent class and define the actual library that is loaded in a subclass as several of my tables have the same structure but different data. My guess is you made so that you no longer have to copy libraries and models to different objects, they are already there. Unfortunately it also tightly couples all of the loaded modules together more rather than allowing them to work independently of each other. You can manually override this behavior by either explicitly declaring the variable and creating another instance of it ($this->loaded_model = new Asdf_mode()) or explicitly copying it ($this->loaded_model = CI::$APP->loaded_model but this is counter to CI's methodology.

I have used your library for about 6-8 months now and greatly admire your work. Coming out with a PHP5 version that fully supports OOP is a great thing, I wish CI would follow your lead. I find ME to be very useful and I would like to continue to use it but I see replacing this fundamental piece of how classes work, particularly the Controller class in CI, to be a major issue.

Thank you very much for your library,
dcunited