help on user authorization

[eluser]Colin Williams[/eluser]
Well, right away it is clear that you are running two identical queries, something you should never have to do. Consider caching results in a property of your model. This means you'll always check your cache property first, then run the query if you don't find it there. You'll also need to remember to update your cache when the data is manipulated (per request only.)

Prototype:

Code:

class User extends Model {
  var $users = array();

  function get($uid)
  {
    if (!isset($this->users[$uid]))
    {
      // 1) Query the db: $user = $this->db->get() ...
      // 2) Add result to $this->users cache
    }
    else
    {
      // $user = $this->users[$uid]
    }
    return $user;
  {
}

Also, I see no need to run two checks to do the login. You could simply have an authenticate() method that returns false on the conditions a) there is no such user in the database, or b) the password for the user is wrong.