Welcome Guest, Not a member yet? Register   Sign In
Doctype Plugin
#6

[eluser]xwero[/eluser]
Now the people have two ways of adding the doctype. Personally i don't like your error messages they don't belong in a professional environment.

There are more doctype than you added and you don't know which doctype someone needs so instead of updating it yourself or let a developer alter the plugin himself putting the doctypes in a config file is the most flexible way to generate the html output.

Also you code is too complex for such a easy generation. If another $lang is needed it requires another elseif around line 30. Keep your code as compact and flexible as possible that is what i'm trying to point out.


Messages In This Thread
Doctype Plugin - by El Forum - 09-02-2008, 02:45 PM
Doctype Plugin - by El Forum - 09-02-2008, 03:19 PM
Doctype Plugin - by El Forum - 09-02-2008, 03:36 PM
Doctype Plugin - by El Forum - 09-03-2008, 02:28 AM
Doctype Plugin - by El Forum - 09-03-2008, 03:14 AM
Doctype Plugin - by El Forum - 09-03-2008, 03:42 AM
Doctype Plugin - by El Forum - 09-03-2008, 04:02 AM
Doctype Plugin - by El Forum - 09-13-2008, 04:27 AM



Theme © iAndrew 2016 - Forum software by © MyBB