parse_smileys and HTML entities bug

[eluser]dmorin[/eluser]
Please see http://ellislab.com/forums/viewthread/92415/ for previous discussion.

I store all user input in the database escaped using xss_clean and htmlentites. Then, when I echo out certain fields, I use the parse_smileys function to generate the image tags. The problem occurs when someone uses an htmlentity character directly before a closed parenthesis such as

(“TEST”)

which I then translate to

("TEST&quot

which the parse_smileys function then interprets the last two characters to be a wink.

It doesn’t appear that these forums are affected by this, so we have to conclude that they use a different parser. While some may argue that this is not a bug, I believe it is because fixing it requires changes to the parse_smileys core function.