parse_smileys and HTML entities bug

[eluser]dmorin[/eluser]
I agree with you. What I'm getting at is, for safety and valid html, any user input should be encoded before added to the html (I think most will agree with that). Since you can't encode text AFTER passing it through that function without ruining the img links, you must do it before. And passing in encoded text causes smileys in unintentional places.

Just so that everyone is on the same page, let's use an example. Say someone posts a comment:

This is my comment ("just for fun")

How would you deal with this? What functions would you pass it through in what order to parse the smileys and echo it safely to the page? You can store it however you please.

If someone can come up with the right approach using the current parse_smileys function then I agree it's not a bug and I was just being an idiot.