MeNeedz Auth

MeNeedz Auth

El Forum
Guest

#167

07-17-2009, 11:32 AM

[eluser]meteor[/eluser]
Well, in my opinion checking if something is false (no data) or '' (empty) is validating ... and it means that we are validating twice here ... Have a look how long that if condition is ... It's slows things down and repeats operation which should have already been done ... just to return false... in my opinion this fragment of code should be refactored. This function is supposed to return true (in case of successful registration) or false ... so it should be given 100 % valid data. If data is not valid it should not be run. What's more it would be good to delegate optional object to this function to save data with ... If something went wrong with saving ... Array of errors would be returned ... otherwise true ...

Just my humble opinion ... Wink

))

Messages In This Thread

MeNeedz Auth - by El Forum - 11-09-2008, 04:23 PM

MeNeedz Auth - by El Forum - 11-09-2008, 05:22 PM

MeNeedz Auth - by El Forum - 11-09-2008, 08:19 PM

MeNeedz Auth - by El Forum - 11-10-2008, 02:14 AM

MeNeedz Auth - by El Forum - 11-10-2008, 04:16 AM

MeNeedz Auth - by El Forum - 11-10-2008, 05:44 AM

MeNeedz Auth - by El Forum - 11-10-2008, 06:14 AM

MeNeedz Auth - by El Forum - 11-10-2008, 06:51 AM

MeNeedz Auth - by El Forum - 11-10-2008, 07:48 AM

MeNeedz Auth - by El Forum - 11-10-2008, 08:21 AM

MeNeedz Auth - by El Forum - 11-10-2008, 08:26 AM

MeNeedz Auth - by El Forum - 11-10-2008, 06:12 PM

MeNeedz Auth - by El Forum - 11-10-2008, 06:36 PM

MeNeedz Auth - by El Forum - 11-10-2008, 07:23 PM

MeNeedz Auth - by El Forum - 11-10-2008, 07:35 PM

MeNeedz Auth - by El Forum - 11-10-2008, 10:32 PM

MeNeedz Auth - by El Forum - 11-11-2008, 03:02 AM

MeNeedz Auth - by El Forum - 11-12-2008, 08:37 AM

MeNeedz Auth - by El Forum - 11-12-2008, 02:27 PM

MeNeedz Auth - by El Forum - 11-13-2008, 12:44 PM

MeNeedz Auth - by El Forum - 11-14-2008, 07:16 AM

MeNeedz Auth - by El Forum - 11-15-2008, 10:42 AM

MeNeedz Auth - by El Forum - 11-15-2008, 02:21 PM

MeNeedz Auth - by El Forum - 11-15-2008, 07:33 PM

MeNeedz Auth - by El Forum - 11-16-2008, 11:56 PM

MeNeedz Auth - by El Forum - 11-17-2008, 07:55 AM

MeNeedz Auth - by El Forum - 11-17-2008, 11:05 PM

MeNeedz Auth - by El Forum - 11-18-2008, 02:39 AM

MeNeedz Auth - by El Forum - 11-18-2008, 03:08 AM

MeNeedz Auth - by El Forum - 11-18-2008, 03:17 AM

MeNeedz Auth - by El Forum - 11-18-2008, 03:20 AM

MeNeedz Auth - by El Forum - 11-18-2008, 05:17 AM

MeNeedz Auth - by El Forum - 11-18-2008, 06:53 AM

MeNeedz Auth - by El Forum - 11-18-2008, 09:08 AM

MeNeedz Auth - by El Forum - 11-19-2008, 01:27 AM

MeNeedz Auth - by El Forum - 11-19-2008, 02:26 AM

MeNeedz Auth - by El Forum - 11-19-2008, 08:17 AM

MeNeedz Auth - by El Forum - 11-19-2008, 10:29 AM

MeNeedz Auth - by El Forum - 11-19-2008, 11:19 AM

MeNeedz Auth - by El Forum - 11-19-2008, 01:08 PM

MeNeedz Auth - by El Forum - 11-19-2008, 01:31 PM

MeNeedz Auth - by El Forum - 11-19-2008, 02:33 PM

MeNeedz Auth - by El Forum - 11-19-2008, 03:27 PM

MeNeedz Auth - by El Forum - 11-19-2008, 03:38 PM

MeNeedz Auth - by El Forum - 11-19-2008, 03:47 PM

MeNeedz Auth - by El Forum - 11-19-2008, 04:05 PM

MeNeedz Auth - by El Forum - 11-19-2008, 04:07 PM

MeNeedz Auth - by El Forum - 11-19-2008, 04:13 PM

MeNeedz Auth - by El Forum - 11-19-2008, 04:20 PM

MeNeedz Auth - by El Forum - 11-19-2008, 04:21 PM

MeNeedz Auth - by El Forum - 11-19-2008, 04:37 PM

MeNeedz Auth - by El Forum - 11-19-2008, 04:41 PM

MeNeedz Auth - by El Forum - 11-19-2008, 05:55 PM

MeNeedz Auth - by El Forum - 11-20-2008, 02:21 AM

MeNeedz Auth - by El Forum - 11-20-2008, 02:47 AM

MeNeedz Auth - by El Forum - 11-20-2008, 03:03 AM

MeNeedz Auth - by El Forum - 11-21-2008, 03:48 PM

MeNeedz Auth - by El Forum - 11-21-2008, 05:45 PM

MeNeedz Auth - by El Forum - 11-21-2008, 06:29 PM

MeNeedz Auth - by El Forum - 11-21-2008, 06:49 PM

MeNeedz Auth - by El Forum - 11-21-2008, 06:59 PM

MeNeedz Auth - by El Forum - 11-21-2008, 07:00 PM

MeNeedz Auth - by El Forum - 11-21-2008, 07:39 PM

MeNeedz Auth - by El Forum - 11-21-2008, 07:47 PM

MeNeedz Auth - by El Forum - 11-21-2008, 07:51 PM

MeNeedz Auth - by El Forum - 11-21-2008, 07:54 PM

MeNeedz Auth - by El Forum - 11-21-2008, 08:09 PM

MeNeedz Auth - by El Forum - 11-21-2008, 08:16 PM

MeNeedz Auth - by El Forum - 11-21-2008, 08:26 PM

MeNeedz Auth - by El Forum - 11-22-2008, 03:38 AM

MeNeedz Auth - by El Forum - 11-22-2008, 06:03 AM

MeNeedz Auth - by El Forum - 11-22-2008, 07:06 AM

MeNeedz Auth - by El Forum - 11-22-2008, 07:56 AM

MeNeedz Auth - by El Forum - 11-22-2008, 08:15 AM

MeNeedz Auth - by El Forum - 11-24-2008, 04:29 PM

MeNeedz Auth - by El Forum - 11-24-2008, 05:45 PM

MeNeedz Auth - by El Forum - 11-25-2008, 01:20 PM

MeNeedz Auth - by El Forum - 11-26-2008, 02:28 AM

MeNeedz Auth - by El Forum - 11-26-2008, 02:38 AM

MeNeedz Auth - by El Forum - 11-26-2008, 03:02 AM

MeNeedz Auth - by El Forum - 11-26-2008, 03:08 AM

MeNeedz Auth - by El Forum - 11-26-2008, 03:20 AM

MeNeedz Auth - by El Forum - 11-26-2008, 03:29 AM

MeNeedz Auth - by El Forum - 11-26-2008, 03:40 AM

MeNeedz Auth - by El Forum - 11-26-2008, 03:46 AM

MeNeedz Auth - by El Forum - 11-26-2008, 05:36 AM

MeNeedz Auth - by El Forum - 11-26-2008, 05:40 AM

MeNeedz Auth - by El Forum - 11-26-2008, 06:15 AM

MeNeedz Auth - by El Forum - 11-26-2008, 02:24 PM

MeNeedz Auth - by El Forum - 11-26-2008, 02:31 PM

MeNeedz Auth - by El Forum - 11-30-2008, 04:59 AM

MeNeedz Auth - by El Forum - 12-05-2008, 08:05 AM

MeNeedz Auth - by El Forum - 12-05-2008, 11:17 AM

MeNeedz Auth - by El Forum - 12-05-2008, 02:00 PM

MeNeedz Auth - by El Forum - 12-05-2008, 04:14 PM

MeNeedz Auth - by El Forum - 12-06-2008, 09:10 AM

MeNeedz Auth - by El Forum - 12-06-2008, 12:07 PM

MeNeedz Auth - by El Forum - 12-06-2008, 03:53 PM

MeNeedz Auth - by El Forum - 12-06-2008, 04:10 PM

MeNeedz Auth - by El Forum - 12-10-2008, 05:18 PM

MeNeedz Auth - by El Forum - 12-11-2008, 02:17 AM

MeNeedz Auth - by El Forum - 12-11-2008, 03:29 AM

MeNeedz Auth - by El Forum - 12-11-2008, 04:31 AM

MeNeedz Auth - by El Forum - 12-11-2008, 04:36 AM

MeNeedz Auth - by El Forum - 12-11-2008, 04:42 AM

MeNeedz Auth - by El Forum - 12-11-2008, 05:04 AM

MeNeedz Auth - by El Forum - 12-11-2008, 05:17 AM

MeNeedz Auth - by El Forum - 12-11-2008, 06:18 AM

MeNeedz Auth - by El Forum - 12-11-2008, 06:57 AM

MeNeedz Auth - by El Forum - 12-11-2008, 07:36 AM

MeNeedz Auth - by El Forum - 12-11-2008, 09:50 AM

MeNeedz Auth - by El Forum - 12-12-2008, 06:49 AM

MeNeedz Auth - by El Forum - 12-12-2008, 07:17 AM

MeNeedz Auth - by El Forum - 12-12-2008, 07:24 AM

MeNeedz Auth - by El Forum - 12-12-2008, 07:35 AM

MeNeedz Auth - by El Forum - 12-14-2008, 06:13 PM

MeNeedz Auth - by El Forum - 12-15-2008, 01:48 AM

MeNeedz Auth - by El Forum - 12-15-2008, 02:11 PM

MeNeedz Auth - by El Forum - 12-15-2008, 03:46 PM

MeNeedz Auth - by El Forum - 12-15-2008, 04:08 PM

MeNeedz Auth - by El Forum - 12-15-2008, 05:01 PM

MeNeedz Auth - by El Forum - 12-15-2008, 07:42 PM

MeNeedz Auth - by El Forum - 12-18-2008, 12:48 PM

MeNeedz Auth - by El Forum - 12-23-2008, 06:08 PM

MeNeedz Auth - by El Forum - 12-23-2008, 07:18 PM

MeNeedz Auth - by El Forum - 12-24-2008, 02:30 AM

MeNeedz Auth - by El Forum - 12-24-2008, 04:58 AM

MeNeedz Auth - by El Forum - 12-24-2008, 05:03 AM

MeNeedz Auth - by El Forum - 12-28-2008, 05:27 PM

MeNeedz Auth - by El Forum - 12-29-2008, 12:26 AM

MeNeedz Auth - by El Forum - 12-29-2008, 03:32 PM

MeNeedz Auth - by El Forum - 12-29-2008, 08:13 PM

MeNeedz Auth - by El Forum - 12-30-2008, 02:49 AM

MeNeedz Auth - by El Forum - 12-30-2008, 04:51 AM

MeNeedz Auth - by El Forum - 01-05-2009, 04:16 PM

MeNeedz Auth - by El Forum - 01-05-2009, 05:34 PM

MeNeedz Auth - by El Forum - 01-08-2009, 08:30 AM

MeNeedz Auth - by El Forum - 02-02-2009, 01:33 AM

MeNeedz Auth - by El Forum - 02-02-2009, 03:08 AM

MeNeedz Auth - by El Forum - 02-21-2009, 07:14 PM

MeNeedz Auth - by El Forum - 02-22-2009, 02:15 AM

MeNeedz Auth - by El Forum - 03-04-2009, 06:03 AM

MeNeedz Auth - by El Forum - 03-04-2009, 06:53 AM

MeNeedz Auth - by El Forum - 03-04-2009, 07:02 AM

MeNeedz Auth - by El Forum - 03-10-2009, 12:58 PM

MeNeedz Auth - by El Forum - 03-10-2009, 02:34 PM

MeNeedz Auth - by El Forum - 03-11-2009, 09:15 AM

MeNeedz Auth - by El Forum - 03-11-2009, 09:17 AM

MeNeedz Auth - by El Forum - 03-11-2009, 09:25 AM

MeNeedz Auth - by El Forum - 03-11-2009, 09:34 AM

MeNeedz Auth - by El Forum - 03-11-2009, 09:39 AM

MeNeedz Auth - by El Forum - 03-11-2009, 09:53 AM

MeNeedz Auth - by El Forum - 03-11-2009, 09:59 AM

MeNeedz Auth - by El Forum - 03-11-2009, 10:14 AM

MeNeedz Auth - by El Forum - 03-12-2009, 02:32 AM

MeNeedz Auth - by El Forum - 03-15-2009, 10:42 PM

MeNeedz Auth - by El Forum - 03-16-2009, 01:26 AM

MeNeedz Auth - by El Forum - 03-24-2009, 05:14 PM

MeNeedz Auth - by El Forum - 05-22-2009, 01:22 PM

MeNeedz Auth - by El Forum - 07-17-2009, 10:27 AM

MeNeedz Auth - by El Forum - 07-17-2009, 10:34 AM

MeNeedz Auth - by El Forum - 07-17-2009, 10:44 AM

MeNeedz Auth - by El Forum - 07-17-2009, 10:49 AM

MeNeedz Auth - by El Forum - 07-17-2009, 10:58 AM

MeNeedz Auth - by El Forum - 07-17-2009, 11:07 AM

MeNeedz Auth - by El Forum - 07-17-2009, 11:14 AM

MeNeedz Auth - by El Forum - 07-17-2009, 11:32 AM

MeNeedz Auth - by El Forum - 07-17-2009, 11:38 AM

MeNeedz Auth - by El Forum - 07-17-2009, 11:44 AM

MeNeedz Auth - by El Forum - 07-17-2009, 03:42 PM

MeNeedz Auth - by El Forum - 07-17-2009, 04:57 PM

MeNeedz Auth - by El Forum - 07-18-2009, 12:08 PM

MeNeedz Auth - by El Forum - 07-18-2009, 12:09 PM

MeNeedz Auth - by El Forum - 07-21-2009, 02:21 AM

MeNeedz Auth - by El Forum - 07-21-2009, 02:50 AM

MeNeedz Auth - by El Forum - 07-21-2009, 03:15 AM

MeNeedz Auth - by El Forum - 07-21-2009, 03:23 AM

MeNeedz Auth - by El Forum - 07-21-2009, 03:31 AM

MeNeedz Auth - by El Forum - 07-21-2009, 03:34 AM

MeNeedz Auth - by El Forum - 07-21-2009, 03:40 AM

MeNeedz Auth - by El Forum - 07-21-2009, 03:48 AM

MeNeedz Auth - by El Forum - 07-21-2009, 04:00 AM

MeNeedz Auth - by El Forum - 07-28-2009, 09:27 AM

MeNeedz Auth - by El Forum - 07-28-2009, 11:28 AM

MeNeedz Auth - by El Forum - 07-28-2009, 01:50 PM

MeNeedz Auth - by El Forum - 08-23-2009, 12:06 AM

MeNeedz Auth - by El Forum - 08-23-2009, 12:35 AM

MeNeedz Auth - by El Forum - 01-20-2010, 09:52 AM

MeNeedz Auth - by El Forum - 01-21-2010, 04:19 AM

MeNeedz Auth - by El Forum - 01-21-2010, 04:34 AM

MeNeedz Auth - by El Forum - 01-24-2010, 02:12 PM

MeNeedz Auth - by El Forum - 01-24-2010, 02:22 PM

MeNeedz Auth - by El Forum - 01-24-2010, 02:24 PM

MeNeedz Auth - by El Forum - 01-24-2010, 02:41 PM

MeNeedz Auth - by El Forum - 01-24-2010, 02:47 PM

MeNeedz Auth - by El Forum - 03-16-2010, 01:19 AM

MeNeedz Auth - by El Forum - 03-16-2010, 02:31 AM

MeNeedz Auth - by El Forum - 03-20-2010, 08:04 AM

MeNeedz Auth - by El Forum - 06-14-2010, 02:54 AM