Form field data pulled from database

[eluser]jedd[/eluser]
No prob. I just ask the obvious questions so the smart guys can come along and spot your mistake faster.

One thing that does stand out is this code, though:

Code:

function get_all_field_data($data)  {
        $data = array(
            'customer' => $this->db->get('customers')
        );
    }

Normally you'd do two things differently. First, you'd say ($data = NULL) (or some value) in the function definition. It makes it easier to ...

Secondly you'd actually test to see if you'd been passed some data before rudely overwriting it with your $data = ... line.

One might suggest a third thing a function like 'get_something' would do .. is actually, you know, return something.