query big problem

[eluser]xwero[/eluser]
I find it a bit strange you going to put the method in a model named comments. If you have a comments model you must have a news model so you should call news->by_id($news_id) and comments->for_news_id($news_id).

The idea about splitting up code is to make it simpler.

My method was written to belong to the news model. The controller method would look like this

Code:

function show($news_id = '')
{
    // no id no news item
    if($news_item == '')
    {
       redirect('news');  
    }
    
    $news_item = $this->news->by_id($news_item,true);
    // if there are no properties there is no news item
    if( ! isset($news_item->news_text) )
    {
       redirect('news');
    }

    $content = array();
    
    if(count($news_item->comments) > 0)
    {
        foreach($news_item->comments as $comment)
        {
            $content['comments'] .= $this->load->view('com/com_loop', $comment, true);
        }
    }
    // comments property is no longer needed
    unset($news_item->comments);
    
    $this->load->view('index', array_merge($content,(array)$news_item));
}