Welcome Guest, Not a member yet? Register   Sign In
Two bugs in the docs (crop & missing distinct title page)
#1

[eluser]marcalj[/eluser]
Developing a CMS, when I intend to crop an image I found one solution to my problem reading the php code of a library instead reading docs.

The problem is: if you would like to crop an image that doesn't respect the aspect ratio it will never have the correct dimensions.

You have to disable the option: maintain_ratio.

Seems logical but in the docs shows that this property only affects to resize, but in the init function always do this:
Code:
/*
         * Should we maintain image proportions?
         *
         * When creating thumbs or copies, the target width/height
         * might not be in correct proportion with the source
         * image's width/height.  We'll recalculate it here.
         *
         */    
        if ($this->maintain_ratio === TRUE && ($this->width != '' AND $this->height != ''))
        {
            $this->image_reproportion();
        }

And another issue for accessibility, would be better to show in the title of a page wich part of the docs I'm seeing. When I have the firefox with some CI docs tabs I cannot know wich page is each until I view the page.

I hope it will improve this great framework.


Messages In This Thread
Two bugs in the docs (crop & missing distinct title page) - by El Forum - 08-06-2007, 04:55 AM



Theme © iAndrew 2016 - Forum software by © MyBB