Two almost identical methods but one failing

[eluser]cahva[/eluser]
Does the former return anything as now it would definately give syntax error or did you just forgot to paste the whole method?

Was it supposed be like this:

Code:

function create_client_list()
{
    $clients = array();
    $client_values = NULL;
    $client_keys = NULL;
    $this->db->select('name');
    $this->db->distinct();
    $this->db->order_by('name');
    $clients = $this->db->get('tbl_clients');
    $query = FALSE;
    
    if ($clients->num_rows() > 0)
    {
        foreach ($clients->result() as $client)
        {
            $client_keys[] = $client->name;
            $client_values[] = $client->name;
        }
        $query = array_combine($client_keys, $client_values);
    }
    return $query;
}