Helpers and Other Conventions

IMO valid_email() should not be deprecated, I doubt that filter_var($address, FILTER_VALIDATE_EMAIL) covers possible valid values like these that include international domain names.

This is the email_helper version of valid_email() from CI3:

PHP Code:

if ( ! function_exists('valid_email'))
{
    /**
     * Validate email address
     *
     * @deprecated 3.0.0 Use PHP's filter_var() instead
     * @param string $email
     * @return bool
     */
    function valid_email($email)
    {
        return (bool) filter_var($email, FILTER_VALIDATE_EMAIL);
    }
} 


This is the valid_email() method in CI3's Form_validation library:

PHP Code:

/**
 * Valid Email
 *
 * @param string
 * @return bool
 */
public function valid_email($str)
{
    if (function_exists('idn_to_ascii') && $atpos = strpos($str, '@'))
    {
        $str = substr($str, 0, ++$atpos).idn_to_ascii(substr($str, $atpos));
    }

    return (bool) filter_var($str, FILTER_VALIDATE_EMAIL);
} 


Checking the commit for the difference between the two functions also reveals that the Email library contains yet another copy of this function. The version of the function in the two libraries makes some attempt to deal with non-ASCII domain names, but the version in the email helper does not (probably because the email helper was deprecated over 3 years ago).

Bonfire

Practical CodeIgniter 3
CodeIgniter Testing Guide