PyroCMS v0.9.7.4 - an open-source modular general purpose CMS

[eluser]Phil Sturgeon[/eluser]
[quote author="Doan Du" date="1256328952"]Just upgraded my system to PHP 5.3 and got an error message in libraries/Loader.php at line 414. It's easy to fix (use instantiate_class()). I think you should update the your Loader.php file like the one of CI 1.7.2.[/quote]

Sadly as we are using Matchbox we need to keep the Loader.php file. I can patch it for v0.9.7 with your suggestion which will get it working on 5.3. In v0.9.8 we will switch to using Modular Seperation which only extends the Loader instead of entirely replacing it, meaning it should stay closer to the core Loader as its improved by the EllisLab guys.

[quote author="dinhtrung" date="1256489613"]In Admin Control Panel, when I add new permission, I can choose Module, but only "All Controllers" and "All methods". This page need some jQuery or Ajax script to populate the Controllers and Methods whenever user change Modules. Maybe, store controllers in a variable, store methods as array (controllers_method), then use jQuery to filter them out.[/quote]

All of this information is stored in an XML file details.xml in the module. It is possible its broken, but I cannot test this right now. Could you take a look at application/models/modules_m.php and see whats going wrong?

[quote author="dinhtrung" date="1256489613"]Change the form into a table with all available modules and methods for easy select (like Drupal). Tick the checkbox with value="module_method_controllers", for example.

Store all rules permission in the permission_roles.permissions field, with json_encode($_POST['permissions']) or implode(";", $this->input->post('permission')) and store all those permission data in session. I think this will save a table, and alot of code (to view navigation admin panel, to check for permission...)

I really like the idea of using cache to store permission data (in your MX_Acl library) and DX_Auth regexp to check for permission (like /controllers/* can access all methods in controlles, and /controllers/add/ can only add... etc). Can we change pyroCMS to use the same?[/quote]

Um... Could I get some wireframes or screenshots of how this would work? Not sure I like the idea of removing a normalized DB structure and shoving it in a serialized field, feels like system devolution to me.

[quote author="dinhtrung" date="1256489613"]Is there something I could help?[/quote]

There are ALWAYS things to do. This permissions stuff could be easily improved if you are up for the job, but only when I have worked out how and if the features should be part of PyroCMS. Caching could definitly be handy. Translations would be good too.

[quote author="NateL" date="1256509723"]Any ideas on this installation error?

A PHP Error was encountered

Severity: Warning

Message: Missing argument 1 for installer_m::validate(), called in /home/topside2/public_html/pyrocms/installer/application/controllers/installer.php on line 165 and defined

Filename: models/installer_m.php

Line Number: 184[/quote]

This is something I have tried explaining to Yorick several times but it looks like he still hasn't made the change.

Code:

function validate($data)
{
// Get the database settings from the form
if(isset($data))
{

That DOES NOT work Yorick, it should be...

Code:

function validate($data = array())
{
// Get the database settings from the form
if(!empty($data))
{

The variable $data will either be set, or unset. If it is unset without a default value then PHP will fatal error, meaning the switch is pointless. It will never get to the else.

I am also assuming that $_POST should be passed to this model by application/controllers/installer.php on line 165? Could someone test this as I cannot code at work anymore.

[eluser]Yorick Peterse[/eluser]
[quote author="Phil Sturgeon" date="1256564504"][quote author="Doan Du" date="1256328952"]Just upgraded my system to PHP 5.3 and got an error message in libraries/Loader.php at line 414. It's easy to fix (use instantiate_class()). I think you should update the your Loader.php file like the one of CI 1.7.2.[/quote]

Sadly as we are using Matchbox we need to keep the Loader.php file. I can patch it for v0.9.7 with your suggestion which will get it working on 5.3. In v0.9.8 we will switch to using Modular Seperation which only extends the Loader instead of entirely replacing it, meaning it should stay closer to the core Loader as its improved by the EllisLab guys.

[quote author="dinhtrung" date="1256489613"]In Admin Control Panel, when I add new permission, I can choose Module, but only "All Controllers" and "All methods". This page need some jQuery or Ajax script to populate the Controllers and Methods whenever user change Modules. Maybe, store controllers in a variable, store methods as array (controllers_method), then use jQuery to filter them out.[/quote]

All of this information is stored in an XML file details.xml in the module. It is possible its broken, but I cannot test this right now. Could you take a look at application/models/modules_m.php and see whats going wrong?

[quote author="dinhtrung" date="1256489613"]Change the form into a table with all available modules and methods for easy select (like Drupal). Tick the checkbox with value="module_method_controllers", for example.

Store all rules permission in the permission_roles.permissions field, with json_encode($_POST['permissions']) or implode(";", $this->input->post('permission')) and store all those permission data in session. I think this will save a table, and alot of code (to view navigation admin panel, to check for permission...)

I really like the idea of using cache to store permission data (in your MX_Acl library) and DX_Auth regexp to check for permission (like /controllers/* can access all methods in controlles, and /controllers/add/ can only add... etc). Can we change pyroCMS to use the same?[/quote]

Um... Could I get some wireframes or screenshots of how this would work? Not sure I like the idea of removing a normalized DB structure and shoving it in a serialized field, feels like system devolution to me.

[quote author="dinhtrung" date="1256489613"]Is there something I could help?[/quote]

There are ALWAYS things to do. This permissions stuff could be easily improved if you are up for the job, but only when I have worked out how and if the features should be part of PyroCMS. Caching could definitly be handy. Translations would be good too.

[quote author="NateL" date="1256509723"]Any ideas on this installation error?

A PHP Error was encountered

Severity: Warning

Message: Missing argument 1 for installer_m::validate(), called in /home/topside2/public_html/pyrocms/installer/application/controllers/installer.php on line 165 and defined

Filename: models/installer_m.php

Line Number: 184[/quote]

This is something I have tried explaining to Yorick several times but it looks like he still hasn't made the change.

Code:

function validate($data)
{
// Get the database settings from the form
if(isset($data))
{

That DOES NOT work Yorick, it should be...

Code:

function validate($data = array())
{
// Get the database settings from the form
if(!empty($data))
{

The variable $data will either be set, or unset. If it is unset without a default value then PHP will fatal error, meaning the switch is pointless. It will never get to the else.

I am also assuming that $_POST should be passed to this model by application/controllers/installer.php on line 165? Could someone test this as I cannot code at work anymore.[/quote]

You never talked about that error but I'll fix it anyway

[eluser]dinhtrung[/eluser]
After some mock up, here is what I get.
-- Screenshot included below --

The idea is simple.

Code:

/* File : core_modules/permissions/controllers/admin.php */
$this->data->backendmodules = $this->modules_m->getModules(array('is_backend'=>true));
$this->data->backendcontrollers = array();
$this->data->backendmethods = array();
foreach ($this->data->backendmodules as $r){
    $m = $r["slug"];
    $this->data->backendcontrollers[$m] = $this->modules_m->getControllers($m);
    foreach ($this->data->backendcontrollers[$m] as $c){
            $this->data->backendmethods[$m][$c] = $this->modules_m->getMethods($m, $c);
    }
}

And in the view file, I create a table.

Code:

<fieldset>
    <legend>&lt;?= lang('perm_what_label');?&gt;</legend>
    &lt;?php
        foreach($backendmodules as $m):
    ?&gt;
    <table summary="&lt;?= $m['name']; ?&gt;" >
        <caption>Permission for &lt;?= $m['name']; ?&gt;</caption>
        <thead>
            <th>Controllers</th>
            &lt;?php foreach ($roles as $r) echo "<th>".$r->title."</th>"; ?&gt;
        </thead>
        <tbody>
            &lt;?php                            
            foreach ($backendcontrollers[$m['slug']] as $ctrl):
                echo "<tr>";
                echo "<th>".$ctrl."</th>";
                foreach ($roles as $r){
                    echo "<td>";                        
     foreach ($backendmethods[$m['slug']][$ctrl] as $mt)
                                                          
                        echo form_checkbox($mt, $m["slug"].'_'.$ctrl.'_'.$mt."[".$r->id."]", FALSE);
                        echo form_label($mt, $r->id.$mt);
                        echo "<br>";
                endforeach;                                
                echo "</td>";
                }
            endforeach;
        echo form_fieldset_close();
        endforeach;
                
    ?&gt;        
    </tbody>
</table>
    
</fieldset>

And when the form_validation->run(), I'll get the data in checkbox array like this:

Code:

$foreach ($this->data->roles as $r){
   $data= array();
   $rid = $r->id;
   $data['permission_role_id'] = $rid;
   foreach ($this->data->backendmodules as $m){
      $s = $m['slug'];
      $data['module'] = $s;
      foreach ($this->data->backendcontrollers[$s] as $ctrl)
          foreach ($this->data->backendmethods[$s][$ctrl] as $mt)
              if ($this->input->post($s.'_'.$ctrl.'_'.$mt[$rid]){
                     $data['controller'] = $ctrl;
                     $data['method'] = $mt;
                     $this->permissions_m->newRule($data);
              }
          }
   }
}

It's quite quick & dirty way to wrote like this...

[eluser]Phil Sturgeon[/eluser]
[quote author="Yorick Peterse" date="1256571037"]You never talked about that error but I'll fix it anyway [/quote]

That same error is all over your code. It is in Widgets model quite a few times and I mentioned it to you in person AND on GitHub. :-p

Thanks for getting a fix in.

[quote author="dinhtrung" date="1256578382"]After some mock up, here is what I get.
<a href="http://img39.imageshack.us/img39/3407/screenshot001oj.png"><img src="http://img39.imageshack.us/img39/3407/screenshot001oj.th.png" border="0" alt="Image Hosted by ImageShack.us"/></a>

...............

It's quite quick & dirty way to wrote like this...[/quote]

PLEASE use syntax support. And show some mock-ups of the interface so I can see where you are going with the ideas.

[eluser]dinhtrung[/eluser]
Sorry, I'm quite new to this forum so I don't know how to turn on syntax support. I wrote all code with HTML code tags, but it's seems incorrect. I'll read user guide.
The staff module has a little bug when uploading new image:
Severity: Notice --&gt; Undefined variable: filename_hash var/www/pyrocms/application/libraries/MY_Upload.php 319
To make it work, I change:

Code:

function set_filename($path, $filename)
    {
        if ($this->encrypt_name == TRUE)
        {        
            $filename_hash = md5($filename).$this->file_ext;    
        }
            +    else $filename_hash = $this->file_name;
                    
        if ($this->overwrite == FALSE)
        {        
            if(!file_exists($path.$filename_hash))
            {
                return $filename_hash;
            }

I don't know if this is a correct way to fix this issue, but it worked for me.

[eluser]Phil Sturgeon[/eluser]
Just delete MY_Upload.php. This has been taken care of in the development version.

[eluser]Phil Sturgeon[/eluser]
v0.9.7-beta1 has been tagged and released.

[eluser]Phil Sturgeon[/eluser]
v0.9.7-beta2 has been tagged and released. Now you can install it and add/edit pages. >.<

[eluser]ngkong[/eluser]
installed today (PyroCMS v0.9.7-beta2).

here is what i got:

tried to add a page, i got "Fatal error: Call to undefined function redirect() in /var/www/als/application/libraries/MY_Exceptions.php on line 38". according to the admin section, the url sould be http://localhost/als/network. htaccess is enable. i guess pages.php controller was not called. http://localhost/als/pages/network redirects to error_404.

delete page doesnt work. return "You can not delete the home page!" & "No pages were deleted." msg.

when the session ended, ajax just give blank page. "your session is time out" or redirect to login page would be nice :-)

sometime (not sure when), when i navigate the admin area, it will give foreach error msg. i will paste the error when i saw it again.


this is a brilliant project. thanks for your hard work.

[eluser]Phil Sturgeon[/eluser]
Yeah sorry beta2 is a pile of crap as well. Grab the "bleeding edge" version which is just a copy of the current codebase. We are doing some final testing tonight then will release beta3 or a stable release.