WolfAuth Beta Version 2.0 Is Now Live

[eluser]Vheissu[/eluser]
WolfAuth beta code has been pushed to the repo: https://github.com/Vheissu/WolfAuth-for-Codeigniter-2.0- go and get it kids! I want lots of feedback, any issues logged on the repo and suggestions welcome. No documentation really, so be prepared to get your hands dirty. Still lots of things that need to be completed before it's ready, but it's a start and you can see all of the work I've put into it so far.

For those not familiar with WolfAuth, it's a driver based authentication library I developed a while back and have just re-released which is better in every single way possible over the original.

[eluser]heldrida[/eluser]
Great news! thanks for sharing ;D

[eluser]wiredesignz[/eluser]
I've been looking forward to seeing this driver based Auth library.

My initial observations are:

There are too many calls to get_instance() in the auth helper/wrapper. Use the global $CI instead if you must do things this way. Or better yet make calls to static methods in your Auth library which contains a single static instance of $CI.

I also noticed repeated calls to the config->item() method which will only slow execution down when a single call is all that is needed to get all of your configuration settings.

The DataMapper User model is created and destroyed in every method of the sample Auth driver. Is it not possible to create the User model once and re-use it as needed?

Other than that, keep up the good work.

[eluser]Vheissu[/eluser]
Thanks for the feedback Wiredesignz. It's somewhat rewarding when someone well versed and respected in the CI community such as yourself takes the time to provide feedback on other peoples code. Definitely agree about the helper file, that was probably the most rushed part of the entire project. I cringed at the million and one instances in each function, I'm most likely going to go down the static route which will fix that as you said.

Is there a particular reason that system helpers located in system/helpers use the new instantiation in every function approach? Although none of the CI core helpers are that long, I wonder why they didn't choose a different approach?

Going to rework the config item calls as well. That was also another component I kind of didn't pay much attention too in terms of optimisation. You'll notice the config file has an array for driver specific config values which is being populated in a class variable (which is cool) but then calls to config_item elsewhere for config values that aren't in an array in the auth config file.

Not entirely sure about creating one instance of DataMapper models and re-using. I know you can clone and copy a DataMapper object to reuse it, but in terms of performance not sure if it would be an advantage or a disadvantage, I'm not too familiar with DataMapper optimisation. Perhaps WanWizard might shine some light on this for us.

Thanks for all of the feedback, its a continual process. Still a few things missing and things to check, but it's getting there.

[eluser]mortenfrisi[/eluser]
Looks like a really great system. Keep up the good work!

[eluser]Vheissu[/eluser]
[quote author="mortenfrisi" date="1312648317"]Looks like a really great system. Keep up the good work![/quote]

Thanks bro. Lots of work has gone into it, lots of work to go. I've started on a Facebook driver as a lot of people seem to want Facebook authentication in their projects rather than traditional authentication (which is cool), the FB is by no means complete yet, just started and giving a heads up.

Keep the feedback coming guys. A few updates have already been made since its release. Updates are made almost thrice-daily.

[eluser]Glazz[/eluser]
Hello,

I cant get this to work, clean ci 2.0.2 install, i installed the latest version wolfauth, and i fixed the 2 wolfsql.sql problems myself.

I have the instalation working, but when i go to http://localhost/testauth/login and then http://localhost/testauth it tells me that im not logged in and that im a baby lol :c

----

Edit:

The hashed password for the user admin is incorrect, don't know if is my problem or problem when generating the hashed password, but i tried to add a user, and the password is now wrong, if i hash it myself i get a totally different hashed password

----

Edit 2:

On the file libraries/auth/Auth_simpleauth.php and on line 1267 i have

Code:

$password = $this->create_password($this->generate_random(), $salt);

I think it should be

Code:

$password = $this->create_password($password, $salt);

Since i'm passing a password why you generate a random password? Thats why the hashed password didn't match the password

[eluser]Vheissu[/eluser]
Haha, my bad. Yeah, I just found this issue out myself, my bad. Don't know why I was generating a password when one was being supplied, lol. Besides that, how have you found it?