Welcome Guest, Not a member yet? Register   Sign In
How to contribute code fixes?
#1

[eluser]maxez[/eluser]
I am sorry in advance if this question has been posted over and over again, but I run a search and couldn't find anything.

My question is this: If I find a bug on CodeIgniter (which I did today for example) and wanted to commit the fix to SVN (along with privileges on the bug tracker to open/close/modify bug reports), what would I have to do?

In other words, can I be part of CodeIgniter development? I have posted the bug on the tracker, and I will delve the code right now to fix it on my local copy. If I do (and I have fixed bugs before on my local copy) it would be a shame for you guys to have to go and fix the bug yourself a second time.

Thanks,
Max
#2

[eluser]awpti[/eluser]
Post the bug and your fix code here. Maybe it will be implemented, maybe it won't.

There is no SVN for CI (a point of contention that caused the Kohana fork). EllisLab maintains all their code internally.
#3

[eluser]Colin Williams[/eluser]
I would PM either Derek Allard or Derek Jones with the fix attached. Remember they are busy on EE 2.0. And I don't agree with the contention awpti mentions (if I understand it correctly). It shouldn't be some free-for-all, but it would be good for EllisLab to develop some sort of submission system. In time, I'm sure they will.
#4

[eluser]Derek Jones[/eluser]
That's not correct, awpti, there is public SVN, there just isn't public write access. FWIW, Kohana doesn't have public write access either. Every successful open source project limits who actually can commit changes to the repos.

Max, the bug tracker is the best place for a confirmed bug and fix. We go through the tracker with a fine tooth comb before every release. If it's an improvement, feature, or you are unsure if it's a bug, post it to the forums for the community to bat around.
#5

[eluser]Colin Williams[/eluser]
Quote:It shouldn’t be some free-for-all, but it would be good for EllisLab to develop some sort of submission system. In time, I’m sure they will.

I see now that the bug tracker allows comments. Seems like the intuitive place to post a fix.
#6

[eluser]maxez[/eluser]
[quote author="Derek Jones" date="1218082296"]That's not correct, awpti, there is public SVN, there just isn't public write access. FWIW, Kohana doesn't have public write access either. Every successful open source project limits who actually can commit changes to the repos.

Max, the bug tracker is the best place for a confirmed bug and fix. We go through the tracker with a fine tooth comb before every release. If it's an improvement, feature, or you are unsure if it's a bug, post it to the forums for the community to bat around.[/quote]

Thanks Derek. I wholeheartedly agree that public write access for everybody = complete kaos Smile. I am sure it is a bug. I think I documented it pretty well on the tracker. I will delve the database library code now and if I find a fix I will post a comment to the bug.

Thanks!
Max
#7

[eluser]Derek Jones[/eluser]
Yes, I saw your bug report come in a few minutes ago; I haven't had a chance to inspect it, so anything you have to add will definitely be a time saver when we are able to take a closer look. Thanks!
#8

[eluser]maxez[/eluser]
[quote author="Derek Jones" date="1218083064"]Yes, I saw your bug report come in a few minutes ago; I haven't had a chance to inspect it, so anything you have to add will definitely be a time saver when we are able to take a closer look. Thanks![/quote]

Derek,

I found the bug and fixed it. I posted the fix as a comment of the bug report. I know you are a very busy dude Smile so when you have a moment to go through it, let me know if the way I documented and provided the fixes is the way to go or not in case I find other bugs.

Thanks!
Max




Theme © iAndrew 2016 - Forum software by © MyBB