Fresh Powered - Auth Library

[eluser]louis w[/eluser]
Nice library.

I was looking over your library and just wanted to offer my personal opinion on your style of error checking. I find that having numerous (6 levels deep in your case) nested conditional statements makes code hard to read and manage.

Because you are just checking for errors and triggering the show_error function, you don't necessarily need to nest all your checks. Lines 125 - 175 could be consolidated to this:

Code:

// Error Checking

if($this->config['user_min_length'] >= $this->_length($username))
    show_error('The username is too short.');

if($this->_length($username) >= $this->config['user_max_length'])
    show_error('The username is too long.');

if($this->config['pass_min_length'] <= $this->_length($password))
    show_error('The password is too short.');

if($this->_length($password) <= $this->config['pass_max_length'])
    show_error('The password is too long');

if(!$this->_username_check($username))
    show_error('The username was not found in the database.');

$password = sha1($this->CI->config->item('encryption_key').$password);

if(!$this->_password_check($password))
    show_error('The password does not match out records.');

Not only is this easier to read and look at, it creates less code and makes it easier if you want to turn off just one of the error checking items.

This same style of checking could be applied to your register method.

Again, this is just my opinion.