Carabiner 1.0: Asset Management Library

[eluser]tonydewan[/eluser]
DannyD:

Thanks for the feedback! The first bug you provided comes from not setting all 3 possible attributes in your array. Your fix doesn't quite work, but something like this will:

Code:

if( is_array($dev_file) ){
            
            if( is_array($dev_file[0]) ){
            
                foreach($dev_file as $file){
                    
                    $d = $file[0];
                    $p = (isset($file[1])) ? $file[1] : '';
                    $c = (isset($file[2])) ? $file[2] : $combine;

                    $this->_asset('js', $d, $p, $c);
                
                }
                
            }else{
                
                $d = $dev_file[0];
                $p = (isset($dev_file[1])) ? $dev_file[1] : '';
                $c = (isset($dev_file[2])) ? $dev_file[2] : $combine;
                
                $this->_asset('js', $d, $p, $c);
                
            }
            
        }else{
        
            $this->_asset('js', $dev_file, $prod_file, $combine);
    
        }

Your second bug is also a great find. However, you don't need to set

Code:

$f = $f;

You can just remove that line altogether.

I'll be updating the library to include these fixes. Thanks!



umefarooq:

I haven't got access to a Windows server to test on, but I think this might fix your problem. In the function called _minify, change both lines that look like this:

Code:

$contents = file_get_contents($this->style_path.$file_ref, 'r');

to this:

Code:

$contents = file_get_contents( realpath($this->script_path.$file_ref) );

I think that will fix your problem, but I'm not sure. Let me know if it does, and I'll update the library with those fixes as well.

Note that you'll probably get the same error again, but from a different part of the library. There are four calls to file_get_contents in the _combine function, that will need a similar change.

Thanks for the feedback, everyone.