[Deprecated] DMZ 1.6.2 (DataMapper OverZealous Edition)

[eluser]OverZealous[/eluser]
I'm not sure what these lines are for:

Code:

$related = $user->from_array($_POST, array('username','group'));
$user->save($related);

I'm guessing that isn't doing anything, because $related never has get() called, therefore there is no object to save.

Also, you must check the results of every call to save(). Otherwise, you won't be able to catch errors and report them.

Finally, you should wrap multiple calls to save in a transaction, to ensure that you can rollback any changes if an error occurs:

Code:

$user->trans_begin();

$success = $user->save();
if(!$success) {
    // report error
}

$success = $success && $user->contact->save();
if(!$success) {
    // report error
}

if($success) {
    $user->trans_commit();
} else {
    $user->trans_rollback();
}