RapidDataMapper, a new Object-Relational-Mapper

[eluser]Jelmer[/eluser]
Maybe again something I should have read in the manual, but I couldn't find out how to get a MAX(`column`)/MIN(`column`) done so I added 2 carbon-copies of the count() method in the DB_Query_Select class:

Code:

public function min($column)
{
    if($this->escape)
    {
        // escape the string
        $column = $this->_instance->protectIdentifiers($column);
    }
    
    // save it, so we still can use this query object here
    $tmp = $this->columns;
    
    // construct the MIN
    $this->columns = array('MIN(' . $column . ')');
    
    // call
    $ret = $this->_instance->query($this->__toString());
    
    // reset the columns
    $this->columns = $tmp;
    
    // return unless error
    if($ret === false)
    {
        return false;
    }
    else
    {
        return ($r = $ret->val()) !== false ? $r : false;
    }
}

public function max($column)
{
    if($this->escape)
    {
        // escape the string
        $column = $this->_instance->protectIdentifiers($column);
    }
    
    // save it, so we still can use this query object here
    $tmp = $this->columns;
    
    // construct the MAX
    $this->columns = array('MAX(' . $column . ')');
    
    // call
    $ret = $this->_instance->query($this->__toString());
    
    // reset the columns
    $this->columns = $tmp;
    
    // return unless error
    if($ret === false)
    {
        return false;
    }
    else
    {
        return ($r = $ret->val()) !== false ? $r : false;
    }
}

Good or bad solution?

(EDIT after suggestion of sophistry)