Model Example is Bad in User Guide

[eluser]Unknown[/eluser]
I Am very new to Code Igniter however I have been taught MVC before, I have been reading through the user guide and let me first say how impressive the documentation is. However I have a real disagreement with the example used on page:

http://ellislab.com/codeigniter/user-gui...odels.html

The example extends the running Blog example which is fine however the following function is concerning:

Code:

function insert_entry()
    {
        $this->title   = $_POST['title']; // please read the below note
        $this->content = $_POST['content'];
        $this->date    = time();

        $this->db->insert('entries', $this);
    }

I believe that the reference to the POST variables whether through $this->input->post or $_POST violates the fundamental ideal of Model in MVC. The model by its very nature should be abstracted from the fact that this is even a web implementation let alone be directly referencing POST variables. This function should take "title" and "content" as parameters so that it may be called from anywhere in the program even if it was not directly related to a POST request.

From my understanding of MVC each layer should be isolated from each other sharing only an interface. This type of function removes any and all benefits of MVC, and is a particularly bad example to show as an introduction to Model. The interface between Model and Controller should pass ALL necessary information across so regardless of what changes as long as that interface is adhered to you do not need to recode anything else.

For example: If I now call that function like so

Code:

$this->Blog_Model->insert_entry()

1) It is not clear what this is going to insert.
2) If this is called from a place where the POST values are not available or not related to what you wish to insert. Your function no longer works.

I believe that this needs correction because it is the first introduction to models given to newcomers.

Regards Boblemur