[eluser]Fierymind[/eluser]
well, its not very stupid
but its unpredictable!
this part of the software handle payment feeds from different sources via different methods, good payment processors send IPN like Paypal, some old processors send information as series of arguments to URL, when payment received the controller save it to a table.
but what if there is refund or charge back? payment processor call same controller to search for the invoice entry and update it.
payment processor send his own ref number of the invoice, it can be string to number .. so my invoices model will search using what the payment processor sent to update the invoice.
software in production since a full year, have over 100k of invoices recorded until one day, a payment processor sent 0 instead of ref number of the invoice!!! and ALL 100k records now have same refund entry
so its very hard to predict this behavior and its very hard to assume that 0 in WHERE clause = ALL rows in table .. I can understand if WHERE in this case select no rows .. but select ALL rows!! wow this is really hard to understand.
