DataMapper ORM v1.8.0

[eluser]Burton Kent[/eluser]
I'm not sure if this would be considered a bug, but if you use $object->skip_validation(); then later try to validate the field, unchanged fields will skip validation.

So for example, suppose I have a list of users, and I don't have their complete information. I might insert them with the intention of the users later updating their information. The way things work now, validation couldn't be used to force them to make updates.

This is caused by code at about line 2143 in datamapper.php:

Code:

// Check if property has changed since validate last ran
      if ($related || ! isset($this->stored->{$field}) || $this->{$field} !== $t
his->stored->{$field})

The fix is simple - a flag, a method to set the flag, and a check for the flag.

The flag - At about line 407, insert two lines after the protect $_validated declaration:

Code:

// tracks whether or not the object has already been validated
  protected $_validated = FALSE;
  // forces validation on items that haven't changed
  protected $_force_revalidation = FALSE;

Method to set the flag - At about line 2269 (after the skip_validation() declaration) insert:

Code:

// --------------------------------------------------------------------

  /**
   * Skips validation for the next call to save.
   * Note that this also prevents the validation routine from running until the
next get.
   *
   * @param object $skip If FALSE, re-enables validation.
   * @return  DataMapper Returns self for method chaining.
   */
  public function force_revalidation($force = TRUE)
  {
    $this->_force_revalidation = $force;
    return $this;
  }

Check for the flag - Add one small test to the end of about line 2143 as noted above:

Code:

// Check if property has changed since validate last ran
      if ($related || ! isset($this->stored->{$field}) || $this->{$field} !== $t
his->stored->{$field} || $this->_force_revalidation)

Then to force re-validation just use $object->force_revalidation(); before any $object->save();

This was hard to find because validation worked perfectly for normal or new entries. When I imported data to work with, validation started failing for no apparent reason.