Welcome Guest, Not a member yet? Register   Sign In
Credit card helper
#3

[eluser]jmadsen[/eluser]
[quote author="Aken" date="1329724719"]
I can tell you that you don't need to assign a variable when returning the matching card names. That variable loses scope anyway, so it's useless.
[/quote]

yes, I think we all know that. It makes things a little clearer to read & easier to make adjustments later

[quote author="Aken" date="1329724719"]
There are other changes I would make, but they're either personal preference or incredibly insignificant unless you're running this function thousands of times.
[/quote]

then, uhm...so what?

[quote author="Aken" date="1329724719"]
That Luhn check is actually what's crappy - maybe you should rewrite that one yourself! Smile
[/quote]

really? care to actually explain the problems with it? I didn't want to write a Luhn Algorithm, I wanted to write a credit card name checker.

you just trying to get your post count up or something? what a waste of a post.


Messages In This Thread
Credit card helper - by El Forum - 02-19-2012, 06:46 PM
Credit card helper - by El Forum - 02-20-2012, 12:58 AM
Credit card helper - by El Forum - 02-20-2012, 01:16 AM
Credit card helper - by El Forum - 02-20-2012, 01:55 AM
Credit card helper - by El Forum - 02-20-2012, 03:40 AM
Credit card helper - by El Forum - 02-20-2012, 12:55 PM



Theme © iAndrew 2016 - Forum software by © MyBB