Cache Functions Suggestions

[eluser]Elliot Haughin[/eluser]
Ah, good catch... I've done some work on this, and it turns out that the way around this is to test on the flock with an extra LOCK_NB passed to it...

Output.php line 299:

Replace:

Code:

if ( ! $fp = @fopen($cache_path, 'wb'))
        {
            log_message('error', "Unable to write cache file: ".$cache_path);
            return;
        }
        
        $expire = time() + ($this->cache_expiration * 60);
        
        flock($fp, LOCK_EX);
        fwrite($fp, $expire.'TS--->'.$output);
        flock($fp, LOCK_UN);
        fclose($fp);
        @chmod($cache_path, 0777);

        log_message('debug', "Cache file written: ".$cache_path);

Code:

if ( ! $fp = @fopen($cache_path, 'wb'))
        {
            log_message('error', "Unable to write cache file: ".$cache_path);
            return;
        }
        else
        {
            $expire = time() + ($this->cache_expiration * 60);

            if ( flock($fp, LOCK_EX | LOCK_NB) )
            {
                fwrite($fp, $expire.'TS--->'.$output);
                flock($fp, LOCK_UN);

                log_message('debug', "Cache file written: ".$cache_path);
            }
            else
            {
                log_message('debug', "Cache file not written (due to locking): ".$cache_path);
                return;
            }

            fclose($fp);
            @chmod($cache_path, 0777);
        }

I'll forward this little gem on to Derek Allard... I'm sure he'll notice this anyway, but nice catch Rick, hopefully this solution should solve this situation.