improve Query Builder to make more complex queries

Looks like someone has submitted a PR for this that I'll review shortly.

It was my PR, but without query grouping.

I am interested in your opinion on the query grouping that I suggested above.

I like your query grouping idea. Personally, I wouldn't mind seeing more streamlining across the database engine like this, but hand my hands full with everything else going on I didn't want to touch anything like that until the framework got to an official release. And I had enough problems with the db refactoring I did do that I didn't want to touch that whole layer anymore than I had to back then.

Support Development •  CodeIgniter 4 Foundations • Practical CodeIgniter 3  • CodeIgniter Tutorials

I like your query grouping idea. Personally, I wouldn't mind seeing more streamlining across the database engine like this, but hand my hands full with everything else going on I didn't want to touch anything like that until the framework got to an official release. And I had enough problems with the db refactoring I did do that I didn't want to touch that whole layer anymore than I had to back then.

And a few more questions.
What to do with the old version of the query grouping (group_start(), etc.)?
Leave for backward compatibility or remove completely?

For query grouping, create a new PR or update an existing one to avoid merge conflicts?

And a few more questions.
What to do with the old version of the query grouping (group_start(), etc.)?
Leave for backward compatibility or remove completely?

For query grouping, create a new PR or update an existing one to avoid merge conflicts?

It's a new feature - so new PR please.

Leave for backward compatibility but mark as deprecated in the docs.

Support Development •  CodeIgniter 4 Foundations • Practical CodeIgniter 3  • CodeIgniter Tutorials