• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
CodeIgniter 3.1.1 Released

#16
(10-27-2016, 09:09 AM)Narf Wrote:
(10-27-2016, 08:06 AM)justanotherprogrammer0 Wrote:
(10-23-2016, 05:00 AM)Narf Wrote:
(10-23-2016, 04:59 AM)gxgpet Wrote: The Session has been changed (including docs), making id from ci_sessions be varchar(128). Shouldn't be that mentioned in the changelog?

No.

Since the field changed from 40 -> 128, that suggests to me that the id can now be bigger than 40 characters.  In an existing system, how is there not a risk of a truncation error, resulting in session failures?  It would seem that the changelog (or upgrade instructions) need to instruct you to increase the size of that field.  Why is this not an important detail?  If this isn't a concern, then why would the field have been increased?

You know, it is reasonable for one to ask if we didn't just miss something, but I did already confirm that it is not by mistake and one would think that should be sufficient. Apparently not.

That was done to allow increased lengths on PHP 7.1.
There are no existing applications running on PHP 7.1.
Because PHP 7.1 is not yet released.

Now, there turned out to be a bug in that logic and in order to fix it, we now have to allow increased lengths on established PHP versions, so we'll mention it in the 3.1.2 upgrade instructions. But changing the field size does nothing for existing applications on 3.1.1.

Is there a stone left unturned still?

Please excuse the passive-aggressive response, but if you try to read between the lines so hard, the changelog entry mentioning PHP 7.1 should've explained all that.

With a response like this to the original question, I wouldn't have had to doubt.  I'm sorry to have further bothered you on it, I just needed to be confident my applications wouldn't break if I update the framework.  Thank you for the clarification and your work on the framework!
Reply


Messages In This Thread
CodeIgniter 3.1.1 Released - by jlp - 10-22-2016, 10:23 AM
RE: CodeIgniter 3.1.1 Released - by forgotten - 10-22-2016, 10:34 AM
RE: CodeIgniter 3.1.1 Released - by ciadmin - 10-22-2016, 11:27 AM
RE: CodeIgniter 3.1.1 Released - by InsiteFX - 10-23-2016, 04:03 AM
RE: CodeIgniter 3.1.1 Released - by gxgpet - 10-23-2016, 04:59 AM
RE: CodeIgniter 3.1.1 Released - by Narf - 10-23-2016, 05:00 AM
RE: CodeIgniter 3.1.1 Released - by Narf - 10-27-2016, 09:09 AM
RE: CodeIgniter 3.1.1 Released - by justanotherprogrammer0 - 10-27-2016, 09:31 AM
RE: CodeIgniter 3.1.1 Released - by Narf - 10-27-2016, 10:08 AM
RE: CodeIgniter 3.1.1 Released - by mkhsojib - 10-24-2016, 09:33 PM
RE: CodeIgniter 3.1.1 Released - by dijon - 10-25-2016, 12:39 AM
RE: CodeIgniter 3.1.1 Released - by dijon - 10-25-2016, 01:08 AM
RE: CodeIgniter 3.1.1 Released - by Andryshok - 10-26-2016, 02:59 AM
RE: CodeIgniter 3.1.1 Released - by Narf - 10-26-2016, 05:56 AM
RE: CodeIgniter 3.1.1 Released - by fakhrawy - 10-26-2016, 07:14 AM
RE: CodeIgniter 3.1.1 Released - by reydeang - 10-27-2016, 05:10 PM
RE: CodeIgniter 3.1.1 Released - by bfedderm - 10-31-2016, 08:07 AM
RE: CodeIgniter 3.1.1 Released - by svennd - 11-18-2016, 12:37 PM

Digg   Delicious   Reddit   Facebook   Twitter   StumbleUpon  


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2021 MyBB Group.