[eluser]a&w[/eluser]
Just discovered your library and am playing with it. A few very minor comments:
1. The downloaded config file has version 1.0, not sure if you want to coincide that with 1.0.4 or maybe it hasn't changed and it's still at 1.0.0.
2. As of 1.0.4 the 'ss' is still in there, you probably know that of course.
3. The instructions are easy to follow. One thing you might note though is that you also need to load/autoload the url helper.
4. Currently there is this (around line 550):
Code:
//if (strstr($HTTP_SERVER_VARS["HTTP_ACCEPT_ENCODING"], "gzip"))
When I have error reporting set to E_ALL that generates warnings visible in the head section. I think that syntax is depracated in favor of the following line (if I change to the following the warnings go away):
Code:
if (strstr($_SERVER["HTTP_ACCEPT_ENCODING"], "gzip"))
I noticed you're using __construct, so presumably you're using php 5 so I'd think go with the preferred way?
5. I think I might second a toggle to disable caching/concatenating/minifying etc. for a development site, unless you have another suggestion (I was deleting the 'compressed' directory manually). I could always augment the config file like I do for error_reporting I guess:
Code:
// Determine whether we're working on development or production server:
define('IS_PRODUCTION', ($_SERVER['SERVER_NAME'] != 'localhost'));
/*
|---------------------------------------------------------------
| PHP ERROR REPORTING LEVEL
|---------------------------------------------------------------
|
*/
IS_PRODUCTION ? error_reporting(0) : error_reporting(E_ALL) ;
but if you have an effective way to implement could just as well do something like:
Code:
$this->assetlibpro->development_site = IS_PRODUCTION;
