calling controller functions

[eluser]edhrx[/eluser]
hi,
Is this 'legitimate' code

I have a controller with these functions

function listall($clientid = "")

function save()

listall just just shows a list of stuff. If the $clientid is "" then it gets the clientid from a $this->input->post. The user eventually edits a record and saves the form which uses controllername/save. Works ok.

Is it acceptable (it works) to call the listall function from the save function passing in the clientid variable... should I be using a redirect



Ed.