Spark command not working in controller after upgrade to CI 4.5.2

Hi guys,

I've updated from CI 4.4.6 to 4.5.2. One of my previously working code was calling a spark command in the controller using command(). This no longer works and results in the redirection to my xammp root (i.e. localhost/dashboard).

There are no logs or error messages, so I cannot figure out what's going on. I'm using the legacy auto routing, so perhaps some changes in that area or how the filters work? I've read the change logs and upgrade instructions but nothing is obvious.

If I run the spark command via the command line, it works fine.

Here's a snippet of the controller in question:

PHP Code:

class Update extends BaseController
{        
      
    public function index()
    {        
        $cmd_result = command('app:update');                        
    
        // we never reach here
        log_message('debug', 'hello');
    }    
 
} 


To ensure that the command doesn't do anything that would cause it, I even removed all lines from the run command, but no change in behaviour.

PHP Code:

class Update extends BaseCommand
{
    protected $group      = 'App';
    protected $name        = 'app:update';
    protected $description = 'Checks for any updates.';

    public function run(array $params)
    {
        // even with this empty, the same behaviour exists
    }
} 


I would appreciate any ideas or debugging tips.

Your sample code never redirects a request.
So the cause might be the changes in Filters.
https://codeigniter.com/user_guide/insta...nd-options
https://codeigniter.com/user_guide/insta...tion-order

If you remove all filters, and run, you may get some clue.

ci-phpunit-test | CodeIgniter Testing Guide | CodeIgniter 3 to 4 Upgrade Helper

Your sample code never redirects a request.
So the cause might be the changes in Filters.
https://codeigniter.com/user_guide/insta...nd-options
https://codeigniter.com/user_guide/insta...tion-order

If you remove all filters, and run, you may get some clue.

So I just tested with a blank appstarter-4.5.2 install, with the following code in Home.php and I get the same result. The only other change I made was to enable legacy auto routing in Config/Routing/php. If you could test this on your end, then you could perhaps reproduce?

PHP Code:

namespace App\Controllers;

class Home extends BaseController
{
    public function index(): string
    {
         $cmd_result = command('help'); // the only change I made
        return view('welcome_message');
    }
} 


I cannot reprocude.

Code:

--- a/app/Config/Routing.php
+++ b/app/Config/Routing.php
@@ -94,7 +94,7 @@ class Routing extends BaseRouting
      *
      * If FALSE, will stop searching and do NO automatic routing.
      */
-    public bool $autoRoute = false;
+    public bool $autoRoute = true;

    /**
      * For Defined Routes.
diff --git a/app/Controllers/Home.php b/app/Controllers/Home.php
index 5934333..5874924 100644
--- a/app/Controllers/Home.php
+++ b/app/Controllers/Home.php
@@ -6,6 +6,8 @@ class Home extends BaseController
{
    public function index(): string
    {
+        $cmd_result = command('help');
+
        return view('welcome_message');
    }
}

Code:

$ php spark serve

Navigate to http://localhost:8080/, I see the CI4 Welcome page.

ci-phpunit-test | CodeIgniter Testing Guide | CodeIgniter 3 to 4 Upgrade Helper

Hmm, ok just tested with php spark serve and no issue. But when served via xammp, it doesn't work.

I note when I serve with xammp, I'm running via https whereas with php spark it's http. Could there be something special there?

EDIT: sorry, running with http on xammp also fails.

It seems there is something wrong with your Apache configuration.

ci-phpunit-test | CodeIgniter Testing Guide | CodeIgniter 3 to 4 Upgrade Helper

The code was working prior to the CI upgrade. After the upgrade it no longer works.

I have tested with xampp 8.1.6 and xampp 8.2.4 with same results.

If I do it like this it displays the help in the welcome_meassage.
welcome_message:

PHP Code:

<?= $cmdResult;?>

controller:

PHP Code:

        $data = [
            'company' => 'Pro Covers FX',
            'cmdResult' => command('help'), // the only change I made
        ];
        
        return view('welcome_message', $data); 


What did you Try? What did you Get? What did you Expect?

Joined CodeIgniter Community 2009.  ( Skype: insitfx )

If I do it like this it displays the help in the welcome_meassage.

What webserver are you running? My point is that running any command (even an empty one) on xammp will result the page redirecting to localhost/dashboard. The problem does not occur when running with spark.

---

In debugging further, I went into framework/system/Common.php and added the following code. It seems the service('commands') call triggers the redirect. I don't know anything about what this does (can't load the command runner?) so if anyone can throw some ideas I look into debugging further.

PHP Code:

  function command(string $command)
    {
        log_message('debug', 'before service(commands)');  // this is logged                    
        $runner      = service('commands');                // this triggers redirect
        log_message('after', 'before service(commands)');  // this is never reached 


This code is invalid.

PHP Code:

log_message('after', 'before service(commands)'); 


There is no log level `after`.
https://codeigniter.com/user_guide/gener...og_message

ci-phpunit-test | CodeIgniter Testing Guide | CodeIgniter 3 to 4 Upgrade Helper