CodeIgniter 1.6.3 Maintenance and Security Release

[eluser]Derek Jones[/eluser]

but i was comparing that with “the overhead of an additional function call to avoid code duplication"

Touché :-D Incidentally, I couldn't avoid the fun test while drinking my tea. Eliminating Benchmarking and Hooks in CodeIgniter for Speed Improvement

(I would add the db_set_charset call to the extracted segment)

You'd still need a parent conditional, though, since we don't want to directly return the return value of the abstracted method; further processing is required. So either the original conditional must stay, or a new one testing the return value of the abstracted method.