Welcome Guest, Not a member yet? Register   Sign In
form_textarea() helper missing html entity encoding with form_prep()
#1

[eluser]Unknown[/eluser]
Great work on Code Igniter. It's been a pleasure getting to know it recently.

The reason I'm posting is that I noticed that html entities weren't getting encoded in my <textarea /> fields.

Here's a patch to correct that:
Code:
--- dist/system/helpers/form_helper.php
+++ fix/system/helpers/form_helper.php    2007-08-29 01:11:56.000000000 -0500
@@ -206,6 +206,8 @@
         unset($data['value']); // textareas don't use the value attribute
     }
        
+    $val = form_prep($val);
+
     return "<textarea ".parse_form_attributes($data, $defaults).$extra.">".$val."</textarea>\n";
}
Enjoy.

Just noticed a similar issue with the vals in the form_dropdown() function, by the way. Added the same form_prep($val) line to correct it.




Theme © iAndrew 2016 - Forum software by © MyBB