Welcome Guest, Not a member yet? Register   Sign In
CI 2.0.2 - FTP-Library - Obsolete checks for PHP5 when using chmod.

The FTP-Library in CI 2.0.2 contains obsolete content from CI 1. CI 1 was able to run on PHP 4, too, so it did make sense the following:
// Permissions can only be set when running PHP 5
if ( ! function_exists('ftp_chmod'))
    if ($this->debug == TRUE)
    return FALSE;

and some hints in the user guide (http://ellislab.com/codeigniter/user-gui...s/ftp.html), that chmod-related functions only work on PHP 5.

But now we have CI 2 and according to http://ellislab.com/codeigniter/user-gui...ments.html the entire CI only works on PHP 5, not only chmod-related functions in the FTP library.

The hints in the user guide and the check if function exists does not make sense anymore.

To keep the code clean I suggest removing these hints and these checks.

[eluser]Matthieu Fauveau[/eluser]
Hi, two words for you: pull request Wink

Theme © iAndrew 2016 - Forum software by © MyBB