11-18-2019, 11:35 AM
This "problem" might be documentation or it might be how the class is implemented.
The docs for Configuring the Library state that
Which is not true because the class constructor looks like this.
Note that $config needs to be a BaseConfig object. So, attempting a config override as the docs suggest will result in a TypeError.
The question is: Is the config override to be allowed or not?
I will submit PR(s) either way but need to know what the desired functionality should be.
The docs for Configuring the Library state that
documentation Wrote:You can over-ride any of these settings by passing your own Config object to the Services:
Which is not true because the class constructor looks like this.
PHP Code:
public function __construct(BaseConfig $config = null)
Note that $config needs to be a BaseConfig object. So, attempting a config override as the docs suggest will result in a TypeError.
The question is: Is the config override to be allowed or not?
I will submit PR(s) either way but need to know what the desired functionality should be.