Welcome Guest, Not a member yet? Register   Sign In
CodeIgniter Forums CodeIgniter 4 CodeIgniter 4 Development We need more reviewers!
We need more reviewers!
  • Offline kenjis
    Administrator
  • *******
  • Posts: 3,502
    Threads: 94
    Joined: Oct 2014
    Reputation: 216
#7
09-09-2023, 04:23 PM

(09-07-2023, 11:40 PM)ozornick Wrote: Let's say we change the filters: I know that the code changes the sorting of the array or rename vars. Is she needed there? It's more about business rules than PHP

If you do not know what the specifications should be, you do not know if the change is correct.

In rare cases, the specification is not clear. 
Basically, the User Guide is the specification, but it is not always detailed.

In any case, if you do not know how it should behave, we will need to discuss it first.
Without a common goal, it is impossible to test/review.
ci-phpunit-test | CodeIgniter Testing Guide | CodeIgniter 3 to 4 Upgrade Helper
Reply


Messages In This Thread
We need more reviewers! - by kenjis - 09-07-2023, 04:55 PM
RE: We need more reviewers! - by ozornick - 09-07-2023, 08:09 PM
RE: We need more reviewers! - by kenjis - 09-07-2023, 09:49 PM
RE: We need more reviewers! - by ozornick - 09-07-2023, 11:40 PM
RE: We need more reviewers! - by kenjis - 09-09-2023, 04:23 PM
RE: We need more reviewers! - by tarcisiodev1 - 09-09-2023, 03:20 PM
RE: We need more reviewers! - by kenjis - 09-09-2023, 04:15 PM
RE: We need more reviewers! - by JanFromHamburg - 11-18-2023, 08:22 AM



Theme © iAndrew 2016 - Forum software by © MyBB